Add Kabu vault on Base - #315
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 7e18982): https://oev-docs--pr315-add-kabu-weth-m42joqzz.web.app (expires Thu, 13 Aug 2026 07:48:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f |
Siegrift
requested changes
Aug 5, 2026
Siegrift
left a comment
Collaborator
There was a problem hiding this comment.
Asked my agent to check out the numbers and review:
Numbers all check out. I verified every market id, LLTV and supply cap against Morpho Blue and
the vault contracts on Ethereum, Base and Robinhood, including the FLUID market that has no
allocation right now. Base vault identity is fine too, its owner and curator Safes have the same
signers as the Ethereum ones.
A few things to fix:
1. The idle liquidity explanation is backwards. VaultV2 allocates every deposit to the liquidity
adapter and deallocates from it on withdraw, so it is the entry and exit route rather than an
overflow for what the collateral markets cannot absorb. It is also not residual: Kabu USDC has
352k of its 718k USDC there, dCOMP has 2.59M of 12.67M.
2. "follow the market links for current values" points at the wrong page. A vault's supply cap is
on the vault page, not the market page.
3. Two different markets are both labelled "wstETH / USDC" at 86%. Api3 Core's collateral row is
0x6d2fba32 and its idle row is 0xb323495f, worth disambiguating.
4. The idle table has no supply cap column even though the caps are set: 10M USDC per Ethereum
vault, 450 WETH on Base, 5M USDG on Robinhood.
5. The Api3 Core paragraph used to expand wstETH, cbBTC and kBTC as Lido, Coinbase and Kraken
wrapped. Only the tickers are left now and kBTC is not obvious.
6. "Idle liquidity" is an h3 alongside the vault sections, so the outline reads it as a fifth
vault. The body calls it "liquidity adapter", maybe use that for the heading too.
7. Collateral order in the summary table does not match the per-vault tables. The Base row is
AERO, VIRTUAL, MORPHO, VVV, the table is AERO, VVV, MORPHO, VIRTUAL.
The numbered points feel like worthy low hanging fruit so better add them.
matejfalat
force-pushed
the
add-kabu-weth
branch
from
August 6, 2026 07:48
8b90783 to
7e18982
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related https://github.com/api3dao/morpho-curation/issues/48
This PR adds the new Kabu WETH vault on Base and also adds to every vault a list of markets to display configured LLTV and supply caps.