Skip to content

chore: remove kbcli cluster register when enabling addon#653

Merged
wangyelei merged 6 commits intomainfrom
bugfix/remoev_register_1
Feb 26, 2026
Merged

chore: remove kbcli cluster register when enabling addon#653
wangyelei merged 6 commits intomainfrom
bugfix/remoev_register_1

Conversation

@wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Feb 26, 2026
@wangyelei wangyelei force-pushed the bugfix/remoev_register_1 branch from 42058f8 to 9210e27 Compare February 26, 2026 02:13
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Feb 26, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.95%. Comparing base (546377c) to head (2b98933).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/addon/addon.go 0.00% 5 Missing ⚠️
pkg/cmd/addon/install.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   40.96%   40.95%   -0.01%     
==========================================
  Files         184      184              
  Lines       24652    24658       +6     
==========================================
  Hits        10098    10098              
- Misses      13406    13412       +6     
  Partials     1148     1148              
Flag Coverage Δ
unittests 40.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyelei wangyelei merged commit f98389f into main Feb 26, 2026
12 checks passed
@wangyelei wangyelei deleted the bugfix/remoev_register_1 branch February 26, 2026 03:27
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0

@github-actions github-actions bot added this to the Release 1.0 milestone Feb 26, 2026
@apecloud-bot
Copy link
Collaborator

🤖 says: Error cherry-picking.

Failed to merge submodule addons (not checked out)
hint: Recursive merging with submodules currently only supports trivial cases.
hint: Please manually handle the merging of each conflicted submodule.
hint: This can be accomplished with the following steps:
hint: - come back to superproject and run:
hint:
hint: git add addons
hint:
hint: to record the above merge or update
hint: - resolve any other conflicts in the superproject
hint: - commit the resulting index in the superproject
hint:
hint: Disable this message with "git config set advice.submoduleMergeConflict false"
CONFLICT (submodule): Merge conflict in addons
Auto-merging pkg/cmd/addon/addon.go
Auto-merging pkg/cmd/addon/install.go
error: could not apply f98389f... chore: remove kbcli cluster register when enabling addon (#653)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@apecloud-bot
Copy link
Collaborator

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/22426545534

wangyelei added a commit that referenced this pull request Feb 26, 2026
Co-authored-by: wangyelei <wangyelei@users.noreply.github.com>
(cherry picked from commit f98389f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants