[ZEPPELIN-6629] Fix anchor links hidden under navbar - #5407
Open
world970511 wants to merge 1 commit into
Open
Conversation
| } | ||
|
|
||
| html { | ||
| scroll-padding-top: 60px; |
Member
There was a problem hiding this comment.
Nit: scroll-padding-top: 60px here and .navbar { height: 60px; } further down both hardcode the same 60px value in two separate places. Would it make sense to tie them together with a CSS custom property (e.g. --navbar-height) so they can't drift apart again — that's basically what caused this bug in the first place?
Member
There was a problem hiding this comment.
@world970511 I think we'd better address this issue in this PR. Could you please check this message? 🙏
jongyoul
approved these changes
Aug 10, 2026
jongyoul
self-requested a review
August 10, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Anchor links in the documentation can be hidden behind the fixed 60px navbar.
The existing
maybeScrollToHash()JavaScript workaround uses a hardcoded 57px offset and does not handle explicit named anchors such as<a name="S3">.This PR replaces the JavaScript workaround with
scroll-padding-top: 60px, allowing native fragment navigation to account for the fixed navbar. It also removesmaybeScrollToHash()and its related event handlers.What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6629
How should this be tested?
Run the documentation site locally and verify the following fragments on the Notebook Storage page:
#overview#notebook-storage-in-s3#S3Verify that each target is visible below the fixed navbar.
Also verify the behavior with a mobile-width viewport.
Screenshots
Before/after screenshots for
#S3, if appropriate.Questions