Improve JdbcExecutor traversal by safely handling missing or multiple consumers - #785
Open
mohit-devlogs wants to merge 1 commit into
Open
Improve JdbcExecutor traversal by safely handling missing or multiple consumers#785mohit-devlogs wants to merge 1 commit into
mohit-devlogs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the JdbcExecutor more robust by ensuring that it handles situations where there are either zero consumers or multiple consumers of the execution task gracefully.
Change:
Returns null if the output channel has zero consumers rather than assuming that there is exactly one consumer.
Throws a helpful WayangException if there are multiple consumers of the execution task rather than making any unchecked assumptions.
Keeps the existing behavior intact for the typical case of having exactly one consumer.
This PR replaces my earlier PR for the same change. The branch has been recreated from the latest main after upstream refactoring made rebasing the previous branch impractical.