[Fix][Python] Use standard scikit-build directory#19990
Open
tlopex wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the build-dir configuration in pyproject.toml from "build/{wheel_tag}" to "build". The reviewer raised a valid concern that using "build" can conflict with manual C++ builds by overwriting custom CMake configurations. They suggested isolating Python wheel builds by using a dedicated subdirectory like "build/wheel" instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
{wheel_tag}from the scikit-build build directory, solving the issue #19987 mentionedEach cibuildwheel matrix job runs in an isolated environment, so separate tagged build directories are unnecessary. Using
buildrestores the existingbuild/libdevelopment layout expected bytvm.libinfoand fixes editable installs without adding runtime directory globbing.