Skip to content

[Fix][Python] Use standard scikit-build directory#19990

Open
tlopex wants to merge 1 commit into
apache:mainfrom
tlopex:fix/scikit-build-dir
Open

[Fix][Python] Use standard scikit-build directory#19990
tlopex wants to merge 1 commit into
apache:mainfrom
tlopex:fix/scikit-build-dir

Conversation

@tlopex

@tlopex tlopex commented Jul 12, 2026

Copy link
Copy Markdown
Member

This PR removes {wheel_tag} from the scikit-build build directory, solving the issue #19987 mentioned

Each cibuildwheel matrix job runs in an isolated environment, so separate tagged build directories are unnecessary. Using build restores the existing build/lib development layout expected by tvm.libinfo and fixes editable installs without adding runtime directory globbing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build-dir configuration in pyproject.toml from "build/{wheel_tag}" to "build". The reviewer raised a valid concern that using "build" can conflict with manual C++ builds by overwriting custom CMake configurations. They suggested isolating Python wheel builds by using a dedicated subdirectory like "build/wheel" instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant