Skip to content

[CI][TIRx] Enable compile coverage and fix exposed regressions#19985

Open
tlopex wants to merge 1 commit into
apache:mainfrom
tlopex:ci/tirx-localize-hardware-gates
Open

[CI][TIRx] Enable compile coverage and fix exposed regressions#19985
tlopex wants to merge 1 commit into
apache:mainfrom
tlopex:ci/tirx-localize-hardware-gates

Conversation

@tlopex

@tlopex tlopex commented Jul 11, 2026

Copy link
Copy Markdown
Member

This PR removes the suite-wide TIRx hardware gate, splits mixed CUDA tests into compile and GPU-run variants so regular CI always compiles kernels against explicit target architectures, and skips execution only after compilation when matching hardware is unavailable. It also fixes the parser, type handling, CUDA intrinsic, TMA, FP4/FP8 NVRTC, and shared-memory regressions exposed by the newly enabled compile coverage.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the suite-level hardware gate for TIRX tests, updates target handling in CUDA codegen tests, and adds @pytest.mark.gpu decorators to several test cases. Feedback focuses on correcting an inaccurate return type annotation in _get_source and removing the @pytest.mark.gpu decorators from compile-only tests. Since these compile-only tests do not execute on physical hardware, removing the decorators and specifying concrete target architectures (like sm_90a or sm_100a) inside the tests will allow them to run in CPU-only CI environments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/python/tirx/codegen/test_codegen_cuda.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/copy/test_ld_stmatrix.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/copy/test_reg.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/copy_async/test_smem_tmem.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/copy_async/test_tma.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/gemm/test_gemm_mma_m16n8k_.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/gemm/test_gemm_mma_m16n8k_.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/gemm/test_gemm_mma_m16n8k_.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/gemm_async/test_gemm_async.py Outdated
@tlopex tlopex force-pushed the ci/tirx-localize-hardware-gates branch from 5329af1 to afc143a Compare July 11, 2026 18:48
@tlopex

tlopex commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

@tvm-bot rerun

@tlopex tlopex force-pushed the ci/tirx-localize-hardware-gates branch 3 times, most recently from 7dd8061 to eee3e5e Compare July 13, 2026 01:46
@tlopex tlopex changed the title [CI][Tests] Localize hardware test gates [CI][TIRx] Localize hardware gates to GPU execution Jul 13, 2026
@tlopex tlopex force-pushed the ci/tirx-localize-hardware-gates branch from eee3e5e to 409f503 Compare July 13, 2026 02:52
@tlopex tlopex changed the title [CI][TIRx] Localize hardware gates to GPU execution [CI][TIRx] Enable compile coverage and fix exposed regressions Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant