[CI] Update images to 20260226-030010-8c259a38#18827
[CI] Update images to 20260226-030010-8c259a38#18827mshr-h wants to merge 8 commits intoapache:mainfrom
20260226-030010-8c259a38#18827Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the CI docker images to incorporate recent changes from other PRs, ensuring the CI environment is up-to-date. It also refactors the JVM build system for better consistency in library path management, migrates Python package installations in CI scripts to the faster Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates CI docker images and refactors parts of the build and CI scripts. The changes include:
- Updating the docker image tag in
ci/jenkins/docker-images.ini. - Refactoring the JVM build to use a configurable
runtime.libdirproperty, removing hardcoded build paths frompom.xmlfiles. This is a good improvement for maintainability. - Switching from
pipto the fasteruv pipinstaller in several CI scripts. - Cleaning up CI scripts by removing several commands and obsolete build configurations.
My review focuses on an introduced redundancy in the Makefile. I've suggested removing an apparently obsolete Maven property. The rest of the changes look good and seem to improve the CI infrastructure.
| mvn clean package -P$(JVM_PKG_PROFILE) -Dcxx="$(CXX)" \ | ||
| -Dcflags="$(PKG_CFLAGS)" -Dldflags="$(PKG_LDFLAGS)" \ | ||
| -Dcurrent_libdir="$(TVM_BUILD_PATH)" $(JVM_TEST_ARGS)) | ||
| -Dcurrent_libdir="$(TVM_BUILD_PATH)" -Druntime.libdir="$(TVM_BUILD_PATH)" $(JVM_TEST_ARGS)) |
There was a problem hiding this comment.
The current_libdir property seems to be obsolete now that runtime.libdir has been introduced and is used across the pom.xml files. To avoid redundancy and improve clarity, consider removing the -Dcurrent_libdir argument.
-Druntime.libdir="$(TVM_BUILD_PATH)" $(JVM_TEST_ARGS))
| mvn install -P$(JVM_PKG_PROFILE) -Dcxx="$(CXX)" \ | ||
| -Dcflags="$(PKG_CFLAGS)" -Dldflags="$(PKG_LDFLAGS)" \ | ||
| -Dcurrent_libdir="$(TVM_BUILD_PATH)" $(JVM_TEST_ARGS)) | ||
| -Dcurrent_libdir="$(TVM_BUILD_PATH)" -Druntime.libdir="$(TVM_BUILD_PATH)" $(JVM_TEST_ARGS)) |
There was a problem hiding this comment.
Similar to the jvmpkg target, the current_libdir property seems to be obsolete here as well. It would be cleaner to remove it.
-Druntime.libdir="$(TVM_BUILD_PATH)" $(JVM_TEST_ARGS))
mshr-h
force-pushed
the
ci-tag-20260226-030010-8c259a38
branch
from
3aee22f to
826c764
Compare
- Add configurable `runtime.libdir` for JVM Maven modules - Replace hardcoded `build` paths in native link, core test runtime, and assembly packaging - Pass `-Druntime.libdir=$(TVM_BUILD_PATH)` from `make jvmpkg/jvminstall` - Export `TVM_BUILD_PATH` in local CI docker env to align with `build-gpu` flows
mshr-h
force-pushed
the
ci-tag-20260226-030010-8c259a38
branch
from
826c764 to
d5f35c6
Compare
mshr-h
changed the title
20260226-030010-8c259a38 20260226-030010-8c259a38
|
local ci script ( |
1 participant
Update the CI docker images to include recent changes in #18812 and #18817
Also includes local CI maintenance: