[TARGET] Specify correct mcpu for Metal target tags

[mshr-h]

As per title.

[mshr-h]

Fixes errors below.

/workspace/src/target/llvm/llvm_instance.cc:227: Error: Using LLVM 15.0.7 with `-mcpu=apple-m4` is not valid in `-mtriple=arm64-apple-macos`, using default `-mcpu=generic`

link to recent ci log: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-gpu/detail/PR-18818/3/pipeline/100/

[gemini-code-assist]

Summary of Changes

Hello @mshr-h, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request explicitly specifies the mcpu (machine CPU) for Metal target tags. This ensures that the correct CPU architecture is used when compiling for Apple devices, which can improve performance and compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly updates the Metal target registration by introducing a mcpu parameter to the _register_metal_tag function. This change allows for the accurate specification of the CPU architecture for different Apple GPUs (M1, M2), replacing a previously hardcoded and potentially incorrect value. This improves the flexibility and correctness of the target configurations.

[gemini-code-assist]

Adding type hints to function parameters improves code readability, maintainability, and allows for static analysis. This is a good practice for Python code, especially in a library context.

Suggested change

	def _register_metal_tag(name, max_threads, shared_mem, warp_size, mcpu):
	def _register_metal_tag(name: str, max_threads: int, shared_mem: int, warp_size: int, mcpu: str):

[tqchen]

@mshr-h do u mind look at ci issue

[mshr-h]

windows and macos failures should be solved with #18818