fix: replace 6 bare except clauses with except Exception#18821
fix: replace 6 bare except clauses with except Exception#18821haosenwang1018 wants to merge 1 commit intoapache:mainfrom
Conversation
Summary of ChangesHello @haosenwang1018, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors error handling across several Python files by replacing generic bare Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a good step towards improving code quality by replacing bare except: clauses with except Exception:. This prevents catching system-level exceptions and makes error handling more robust. My review includes a few suggestions to further refine the exception handling by using more specific exception types in some places, and improving a test's skipping logic for better clarity in test results.
| print( | ||
| "This test requires TVM Runtime to be built with a Hexagon gtest" | ||
| "version using Hexagon API cmake flag" |
There was a problem hiding this comment.
Instead of just printing a message, it's better to use pytest.skip to explicitly mark the test as skipped. This provides clearer test results and avoids the test passing silently or failing with a subsequent NameError if func is used later. You'll need to import pytest at the top of the file.
pytest.skip(
"This test requires TVM Runtime to be built with a Hexagon gtest"
"version using Hexagon API cmake flag"
)| except Exception: | ||
| sprint("The out.pkl file is not match with csv file.") | ||
| exit(1) |
There was a problem hiding this comment.
While except Exception: is an improvement, it's good practice to be more specific about the exceptions you expect to catch. In this case, int(number) could raise a ValueError and pr_dict[...] could raise a KeyError. Catching (ValueError, KeyError) would make the error handling more precise.
| except Exception: | |
| sprint("The out.pkl file is not match with csv file.") | |
| exit(1) | |
| except (ValueError, KeyError): | |
| sprint("The out.pkl file is not match with csv file.") | |
| exit(1) |
adaef97 to
a264001
Compare
What
Replace 6 bare
except:clauses withexcept Exception:.Why
Bare
except:catchesBaseException, includingKeyboardInterruptandSystemExit, which can prevent clean process shutdown and mask critical errors. Usingexcept Exception:catches all application-level errors while allowing system-level exceptions to propagate correctly.