Skip to content

fix: replace 6 bare except clauses with except Exception#18821

Open
haosenwang1018 wants to merge 1 commit intoapache:mainfrom
haosenwang1018:fix/bare-excepts
Open

fix: replace 6 bare except clauses with except Exception#18821
haosenwang1018 wants to merge 1 commit intoapache:mainfrom
haosenwang1018:fix/bare-excepts

Conversation

@haosenwang1018
Copy link

What

Replace 6 bare except: clauses with except Exception:.

Why

Bare except: catches BaseException, including KeyboardInterrupt and SystemExit, which can prevent clean process shutdown and mask critical errors. Using except Exception: catches all application-level errors while allowing system-level exceptions to propagate correctly.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @haosenwang1018, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors error handling across several Python files by replacing generic bare except statements with more specific except Exception clauses. This modification enhances the reliability and predictability of the codebase by ensuring that only application-level exceptions are caught, preventing the accidental suppression of critical system-level signals and improving overall error management.

Highlights

  • Improved Exception Handling: Replaced 6 instances of bare except: clauses with except Exception: to prevent catching system-exiting exceptions like KeyboardInterrupt and SystemExit.
  • Enhanced Robustness: This change ensures that only application-level errors are caught, allowing critical system-level exceptions to propagate and be handled appropriately, leading to more robust and predictable program behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/tvm/relax/frontend/torch/fx_translator.py
    • Updated exception handling for dynamo.export to catch Exception instead of a bare except.
  • python/tvm/runtime/_tensor.py
    • Modified exception handling for np.array conversion to catch Exception instead of a bare except.
  • python/tvm/s_tir/dlight/analysis/common_analysis.py
    • Adjusted exception handling for sch.mod[func_name].body.block access to catch Exception instead of a bare except.
  • tests/python/contrib/test_hexagon/test_run_unit_tests.py
    • Changed exception handling for hexagon_session._rpc.get_function to catch Exception instead of a bare except.
  • tests/python/relax/test_group_gemm_flashinfer.py
    • Updated exception handling for pynvml calls to catch Exception instead of a bare except.
  • tests/scripts/release/make_notes.py
    • Modified exception handling for pr_dict access to catch Exception instead of a bare except.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good step towards improving code quality by replacing bare except: clauses with except Exception:. This prevents catching system-level exceptions and makes error handling more robust. My review includes a few suggestions to further refine the exception handling by using more specific exception types in some places, and improving a test's skipping logic for better clarity in test results.

Comment on lines 155 to 157
print(
"This test requires TVM Runtime to be built with a Hexagon gtest"
"version using Hexagon API cmake flag"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of just printing a message, it's better to use pytest.skip to explicitly mark the test as skipped. This provides clearer test results and avoids the test passing silently or failing with a subsequent NameError if func is used later. You'll need to import pytest at the top of the file.

        pytest.skip(
            "This test requires TVM Runtime to be built with a Hexagon gtest" 
            "version using Hexagon API cmake flag"
        )

Comment on lines +221 to 223
except Exception:
sprint("The out.pkl file is not match with csv file.")
exit(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While except Exception: is an improvement, it's good practice to be more specific about the exceptions you expect to catch. In this case, int(number) could raise a ValueError and pr_dict[...] could raise a KeyError. Catching (ValueError, KeyError) would make the error handling more precise.

Suggested change
except Exception:
sprint("The out.pkl file is not match with csv file.")
exit(1)
except (ValueError, KeyError):
sprint("The out.pkl file is not match with csv file.")
exit(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant