Skip to content

[REFACTOR][METAL] Update CHECK_LE to TVM_FFI_ICHECK_LE in Metal runtime #18819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 2 commits into from
Feb 25, 2026
+1 −1
Merged

[REFACTOR][METAL] Update CHECK_LE to TVM_FFI_ICHECK_LE in Metal runtime #18819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a85b6f9
fix missing CHECK macros migration
mshr-h Feb 25, 2026
9b0caac
`TVM_FFI_CHECK_LE` -> `TVM_FFI_ICHECK_LE`
mshr-h Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/metal/metal_module.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ void operator()(ffi::PackedArgs args, ffi::Any* rv, const ArgUnion64* pack_args)
ThreadWorkLoad wl = launch_param_config_.Extract(args);
int blockSize = wl.block_dim(0) * wl.block_dim(1) * wl.block_dim(2);
auto maxTotalThreadsPerThreadgroup = scache_[device_id].maxTotalThreadsPerThreadgroup;
CHECK_LE(blockSize, maxTotalThreadsPerThreadgroup);
TVM_FFI_ICHECK_LE(blockSize, maxTotalThreadsPerThreadgroup);
// attach error message directly in this functio
id<MTLCommandBuffer> cb = stream->GetCommandBuffer(/*label=*/"TVMKernel:" + func_name_,
/*attach_error_callback=*/false);
Expand Down
Loading