[DOC] Update installation docs with missing dependencies (#18194)#18808
[DOC] Update installation docs with missing dependencies (#18194)#18808AshwiniBokka wants to merge 2 commits intoapache:mainfrom
Conversation
Based on user report, the installation documentation was missing: 1. System dependencies (zlib1g-dev, libxml2-dev) 2. Cython in Python dependencies 3. Post-build installation step (cd python && pip install -e .) This PR adds these missing steps to rom_source.rst: - Added 'System Dependencies' section with Ubuntu commands - Added Cython to the necessary dependencies - Added 'Installing the Python Package' section after build Fixes apache#18194
Summary of ChangesHello @AshwiniBokka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the installation documentation for building from source, addressing a user report by incorporating crucial missing steps. The changes enhance the clarity and completeness of the installation guide by adding system-level dependencies, an additional Python dependency (Cython), and the final post-build installation command for the Python package, ensuring a smoother setup process for users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly identifies several missing dependencies and steps in the TVM installation documentation. Specifically, adding cython and the required system libraries (zlib1g-dev, libxml2-dev) is a valuable improvement for users not using the Conda-based setup. However, the placement of the "System Dependencies" section is logically inconsistent with the document's flow, as these libraries are required for the build process (Step 3) rather than being "Extra Python Dependencies" (Step 5). Additionally, the new "Installing the Python Package" section is redundant with instructions already present at the end of Step 3. The section headers also introduce an inconsistency in the document's heading hierarchy.
|
@tvm-bot run |
Fixes #18194
Based on user report, the installation documentation was missing:
This PR adds these missing steps to
from_source.rst:Changes:
This addresses all 4 issues reported by the user in #18194.