Skip to content

fix cpp device_id parser#759

Merged
jt2594838 merged 1 commit intoapache:developfrom
hongzhi-gao:fix/cpp-device_id_parser
Mar 31, 2026
Merged

fix cpp device_id parser#759
jt2594838 merged 1 commit intoapache:developfrom
hongzhi-gao:fix/cpp-device_id_parser

Conversation

@hongzhi-gao
Copy link
Copy Markdown
Contributor

@hongzhi-gao hongzhi-gao commented Mar 30, 2026

Summary

Fix path parsing inconsistency between ANTLR4 and fallback flows.

What changed

Moved Path parsing into library .cc (library-controlled behavior).
Fixed fallback split_device_id_string to normalize split results instead of returning raw token splits.
Added unit test for root.sg1.FeederA fallback semantics.
Previously, ENABLE_ANTLR4 was checked in headers, so it depended on user-side compile flags and could be ignored in real usage.

Impact

Prevents device/measurement path mismatches that could make IoTDB queries return empty results even when TsFile content is valid.

@jt2594838 jt2594838 merged commit f621373 into apache:develop Mar 31, 2026
16 checks passed
@jt2594838 jt2594838 deleted the fix/cpp-device_id_parser branch March 31, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants