Remove unreachable code reported by Coverity Scan

plugins/experimental/jax_fingerprint/ja4h/test.cc

@@ -105,7 +105,7 @@ class MockDatasource : public Datasource
 
 private:
   std::string                        _method;
-  int                                _version;
+  int                                _version{};
   std::map<std::string, std::string> _fields{};
 };
 

src/iocore/cache/unit_tests/test_RWW.cc

@@ -240,20 +240,11 @@ class CacheRWWErrorTest : public CacheRWWTest
           this->_read_event = this_ethread()->schedule_imm(this->_rt);
         }
         return;
-      } else {
-        this->close_write(100);
-        return;
-      }
-
-      // write at least one fragment before read it
-      if (this->_latest_fragments == this->_wt->vc->fragment) {
-        base->reenable();
-        return;
       }
 
-      this->_latest_fragments = this->_wt->vc->fragment;
-      this->_rt->reenable();
-      break;
+      // Once the reader has started, abort the writer to exercise the error path.
+      this->close_write(100);
+      return;
 
     case VC_EVENT_WRITE_COMPLETE:
       REQUIRE(!"should not happen because the writer aborted");

src/proxy/hdrs/unit_tests/test_Hdrs.cc

@@ -1131,6 +1131,8 @@ TEST_CASE("HdrTest", "[proxy][hdrtest]")
     if (cc_field == nullptr) {
       std::printf("FAILED: missing Cache-Control header\n\n");
       REQUIRE(false);
+      return; // REQUIRE throws, but make the early exit explicit so the dereferences below are
+              // unreachable to a reader and to the compiler
     }
 
     // TODO: Do we need to check the "count" returned?

src/proxy/http/HttpCacheSM.cc

@@ -440,7 +440,7 @@ HttpCacheSM::open_write(const HttpCacheKey *key, URL *url, HTTPHdr *request, Cac
   CacheHTTPInfo *info          = allow_multiple ? reinterpret_cast<CacheHTTPInfo *>(CACHE_ALLOW_MULTIPLE_WRITES) : old_info;
   Action        *action_handle = nullptr;
 
-  if (master_sm && master_sm->t_state.cache_info.volume_host_rec) {
+  if (master_sm->t_state.cache_info.volume_host_rec) {
     action_handle =
       cacheProcessor.open_write(this, key, info, pin_in_cache, CACHE_FRAG_TYPE_HTTP, master_sm->t_state.cache_info.volume_host_rec);
   } else {

src/proxy/http/remap/RemapYamlConfig.cc

@@ -183,10 +183,8 @@ remap_validate_yaml_filter_args(acl_filter_rule **rule_pp, const YAML::Node &nod
         return {};
       }
     }
-    if (ipi) {
-      rule->src_ip_cnt++;
-      rule->src_ip_valid = 1;
-    }
+    rule->src_ip_cnt++;
+    rule->src_ip_valid = 1;
     return {};
   };
 
@@ -239,10 +237,8 @@ remap_validate_yaml_filter_args(acl_filter_rule **rule_pp, const YAML::Node &nod
         return {};
       }
     }
-    if (ipi) {
-      rule->src_ip_category_cnt++;
-      rule->src_ip_category_valid = 1;
-    }
+    rule->src_ip_category_cnt++;
+    rule->src_ip_category_valid = 1;
     return {};
   };
 
@@ -284,10 +280,8 @@ remap_validate_yaml_filter_args(acl_filter_rule **rule_pp, const YAML::Node &nod
         return {};
       }
     }
-    if (ipi) {
-      rule->in_ip_cnt++;
-      rule->in_ip_valid = 1;
-    }
+    rule->in_ip_cnt++;
+    rule->in_ip_valid = 1;
     return {};
   };