Skip to content

Guard the shutdown log wakeup against an unallocated notify array #13541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bryancall wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −3
Draft

Guard the shutdown log wakeup against an unallocated notify array #13541

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e78d924
Guard the shutdown log wakeup against an unallocated notify array
bryancall Aug 13, 2026
6f9f2b1
Widen the comment to cover the permanent null case
bryancall Aug 13, 2026
547fbb6
Drop the log-only tools from the comment
bryancall Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/traffic_server/traffic_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,13 @@ struct AutoStopCont : public Continuation {
CacheShm::mark_clean_shutdown();
}

// Wake preproc threads to drain remaining log buffers before exit.
for (int i = 0; i < Log::preproc_threads; i++) {
Log::preproc_notify[i].signal();
// Wake preproc threads to drain remaining log buffers before exit. The notify array is allocated only when the log
// threads are spawned, which happens well after Log::init() during startup and not at all in command mode, so a
// null array means there is no preproc thread in existence and nothing to wake.
if (Log::preproc_notify != nullptr) {
for (int i = 0; i < Log::preproc_threads; i++) {
Log::preproc_notify[i].signal();
}
}
delete this;
return EVENT_CONT;
Expand Down