Skip to content

Avoid confusing AIO callback lifetime test #13159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
May 13, 2026
+15 −12
Merged

Avoid confusing AIO callback lifetime test #13159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/iocore/aio/unit_tests/test_AIOCallback.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,33 +23,36 @@

#include <catch2/catch_test_macros.hpp>

#include <memory>

#include "iocore/aio/AIO.h"
#include "iocore/eventsystem/Event.h"

namespace
{

struct AIOCompletionOwner : Continuation {
AIOCallback callback;
bool *completed = nullptr;
std::unique_ptr<AIOCallback> callback;
bool *completed = nullptr;

explicit AIOCompletionOwner(bool &completion_flag) : Continuation(nullptr), completed(&completion_flag)
explicit AIOCompletionOwner(bool &completion_flag)
: Continuation(nullptr), callback(std::make_unique<AIOCallback>()), completed(&completion_flag)
{
SET_HANDLER(&AIOCompletionOwner::handle_aio_complete);

callback.action = this;
callback.aiocb.aio_nbytes = 0;
callback.aio_result = 0;
callback->action = this;
callback->aiocb.aio_nbytes = 0;
callback->aio_result = 0;
}

int
handle_aio_complete(int event, void *data)
{
CHECK(event == AIO_EVENT_DONE);
CHECK(data == &callback);
CHECK(data == callback.get());

*completed = true;
delete this;
callback.reset();
return EVENT_DONE;
}
};
Expand Down Expand Up @@ -84,11 +87,11 @@ struct DeletionTrackedAIOCallback : AIOCallback {

} // namespace

TEST_CASE("AIOCallback completion tolerates owner deletion", "[iocore][aio]")
TEST_CASE("AIOCallback completion tolerates callback deletion", "[iocore][aio]")
{
bool completed = false;
auto owner = new AIOCompletionOwner(completed);
auto callback = &owner->callback;
bool completed = false;
AIOCompletionOwner owner(completed);
auto *callback = owner.callback.get();

// Without ASan, a broken implementation can still pass because the stale value of from_ts_api is typically false.
CHECK(callback->io_complete(EVENT_NONE, nullptr) == EVENT_DONE);
Copy link
Copy Markdown
Contributor

@zwoop zwoop May 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important, but after completing this, I think callback is in an undefined state. We don't use it after this, but maybe we should NULL it out or something ? In case someone looks at this after we retire.

Expand Down