ArgParser Fix: apply default values after dependency validation

[brbzull0]

ArgParser: apply default values after dependency validation
validate_dependencies() incorrectly triggers on options that have default values but were not explicitly passed by the user.

The root cause is that append_option_data() populates default values into the Arguments map before validate_dependencies() runs. When validate_dependencies() calls ret.get(key) for an option with a default, the lookup finds the entry and sets _is_called = true, making the option appear "used" even though the user never specified it on the command line.

Fix by extracting the default-value loop into apply_option_defaults() and calling it after validate_dependencies() in parse().

Test also checks for Case sensitive short options which I needed to make sure they are working.

[Copilot]

Pull request overview

Updates ts::ArgParser parsing flow so option default values are applied after dependency validation, preventing options with defaults from being treated as “explicitly used” during with_required() checks.

Changes:

• Extracted default-value population into ArgParser::Command::apply_option_defaults() and invoked it after validate_dependencies() in Command::parse().
• Added unit tests to confirm (1) short option case-sensitivity and (2) with_required() is not triggered by defaulted-but-not-specified options.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/tscore/unit_tests/test_ArgParser.cc	Adds coverage for short-option case sensitivity and for dependency validation not being triggered by default values.
src/tscore/ArgParser.cc	Moves default application to a dedicated helper and runs it after dependency validation.
include/tscore/ArgParser.h	Declares the new apply_option_defaults() helper on ArgParser::Command.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/tscore/ArgParser.cc:745

• apply_option_defaults() doesn't modify Command state and is only reading _option_list, so it can be marked const (and declared const in the header) for correctness and to match the existing validate_* helpers. This also prevents accidental future mutation of command state during default application.

void
ArgParser::Command::apply_option_defaults(Arguments &ret)
{
  for (const auto &it : _option_list) {
    if (!it.second.default_value.empty() && ret.get(it.second.key).empty()) {
      std::istringstream ss(it.second.default_value);
      std::string        token;
      while (std::getline(ss, token, ' ')) {
        ret.append_arg(it.second.key, token);
      }
    }
  }
}