Add AuTest for connect_attempts rr_retries and max_retries#12932
Add AuTest for connect_attempts rr_retries and max_retries#12932masaori335 wants to merge 4 commits intoapache:masterfrom
Conversation
ab39cfa to
3b069bc
Compare
There was a problem hiding this comment.
Pull request overview
Adds new AuTest coverage for origin connect-attempt retry behaviors (round-robin retries vs max retries) and extends the ATS replay test harness to support DNS record injection and error.log validation via replay YAML.
Changes:
- Added three new Proxy Verifier replay scenarios covering
proxy.config.http.connect_attempts_rr_retriesandproxy.config.http.connect_attempts_max_retries. - Added new
dns/connect_attempts.test.pyto run the new replay tests and gold files forerror.logexpectations. - Extended
tests/gold_tests/autest-site/ats_replay.test.extto support DNSrecordsinjection anderror_logvalidation (including gold-file based validation).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/gold_tests/dns/replay/connect_attempts_rr_retries.replay.yaml | New replay scenario for round-robin retry behavior and down-server cache behavior. |
| tests/gold_tests/dns/replay/connect_attempts_rr_no_retry.replay.yaml | New replay scenario covering baseline behavior with no retries. |
| tests/gold_tests/dns/replay/connect_attempts_rr_max_retries.replay.yaml | New replay scenario covering connect_attempts_max_retries behavior. |
| tests/gold_tests/dns/gold/connect_attempts_rr_retries_error_log.gold | Expected error.log output for rr-retries scenario. |
| tests/gold_tests/dns/gold/connect_attempts_rr_no_error_log.gold | Expected error.log output for no-retry scenario. |
| tests/gold_tests/dns/gold/connect_attempts_rr_max_retries_error_log.gold | Expected error.log output for max-retries scenario. |
| tests/gold_tests/dns/connect_attempts.test.py | Test driver that runs the three new replay tests. |
| tests/gold_tests/autest-site/ats_replay.test.ext | Adds error_log validation support and DNS records wiring for replay-based tests. |
tests/gold_tests/dns/replay/connect_attempts_rr_no_retry.replay.yaml
Outdated
Show resolved
Hide resolved
tests/gold_tests/dns/replay/connect_attempts_rr_no_retry.replay.yaml
Outdated
Show resolved
Hide resolved
tests/gold_tests/dns/replay/connect_attempts_rr_max_retries.replay.yaml
Outdated
Show resolved
Hide resolved
tests/gold_tests/dns/replay/connect_attempts_rr_max_retries.replay.yaml
Outdated
Show resolved
Hide resolved
tests/gold_tests/dns/replay/connect_attempts_rr_retries.replay.yaml
Outdated
Show resolved
Hide resolved
tests/gold_tests/dns/replay/connect_attempts_rr_retries.replay.yaml
Outdated
Show resolved
Hide resolved
|
Somehow, the |
|
I found difference on my mac and docker env. We're hitting An idea of speed up this test is adding some features to proxy-verifer to refuse connection immediately. |
Covers combination of
proxy.config.http.connect_attempts_rr_retriesandproxy.config.http.connect_attempts_max_retries.The
connect_attempts_max_retries_down_serverwill be covered by #12922