Open
Conversation
vmamidi
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new proxy.config.http.connect.down.policy value (3) intended to treat origin server inactivity timeouts (after a connection is established) as failures for the purposes of marking an origin down.
Changes:
- Extend
HttpSM::track_connect_fail()to recognizeconnect_down_policy == 3, including an additional timeout-based condition. - Update admin documentation to describe the new policy value
3.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/proxy/http/HttpSM.cc |
Updates server-down tracking logic to treat policy 3 as “policy 2 + inactivity timeout” behavior. |
doc/admin-guide/files/records.yaml.en.rst |
Documents the new connect.down.policy = 3 option and its intended effect. |
tests/gold_tests/connect_down_policy/connect_down_policy_3.test.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tests/gold_tests/connect_down_policy/connect_down_policy_3.test.py
Outdated
Show resolved
Hide resolved
masaori335
reviewed
Mar 3, 2026
| // What does our policy say? | ||
| if (t_state.txn_conf->connect_down_policy == 2) { // Any connection error through TLS handshake | ||
| if (t_state.txn_conf->connect_down_policy == 2 || | ||
| t_state.txn_conf->connect_down_policy == 3) { // Any connection error through TLS handshake |
Contributor
There was a problem hiding this comment.
I prefer to make this config bit mask, it'll allow us to choose combination of policies when we have more policies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option 3 to connect down policy to count inactive connections as failures