Don't pool origin connections with unconsumed request body#12926
Open
JakeChampion wants to merge 4 commits intoapache:masterfrom
Open
Don't pool origin connections with unconsumed request body#12926JakeChampion wants to merge 4 commits intoapache:masterfrom
JakeChampion wants to merge 4 commits intoapache:masterfrom
Conversation
JakeChampion
force-pushed
the
jake/100
branch
from
f9e9fb3 to
38328b3
Compare
When an origin responds before consuming a request body sent with `Expect: 100-continue`, ATS was returning the origin connection to the pool with leftover body data in the TCP stream The next request reusing that connection would see the leftover bytes as a corrupted response Fix by recording `server_request_body_bytes` when aborting the tunnel early, then checking it in both connection pooling paths to prevent reuse when a request body was in flight
JakeChampion
changed the title
paulo
approved these changes
Feb 27, 2026
JakeChampion
force-pushed
the
jake/100
branch
from
370a382 to
fc349f0
Compare
… connection pooling issues
Contributor
|
I'll have a look at this. @JakeChampion are you on slack? |
Contributor
Author
I am not, I requested an invite some time last year but I don't think it's been accepted |
Contributor
Ohh, sorry about that. I've just had a look and couldn't find the email. Please send another email to the users@trafficserver.apache.org list and I'll help you with that. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an origin responds before consuming a request body sent with
Expect: 100-continue, ATS was returning the origin connection to the pool with leftover body data in the TCP streamThe next request reusing that connection would see the leftover bytes as a corrupted response
Fix by recording
server_request_body_byteswhen aborting the tunnel early, then checking it in both connection pooling paths to prevent reuse when a request body was in flight