Doc: remove references to set-debug TXN_DEBUG in header_rewrite/hrw4u#12918
Doc: remove references to set-debug TXN_DEBUG in header_rewrite/hrw4u#12918mlibbey wants to merge 1 commit intoapache:masterfrom
Conversation
The set-http-cntl TXN_DEBUG and (deprecated) set-debug need a non-overridable config (proxy.config.diags.debug.enabled) to be on. But, if its on, then you don't need header_rewrite to conditionally turn it on. (I suppose turning it off could be a use case, but, that would also require rewriting the docs).
|
Original discussion:
This sounds like requiring the global setting to be enabled is a bug, but looks like even the initial implementation has the bug. |
|
Another thing that should be noted is that majority of debug prints are not under the control of |
|
Well, if we kill this feature in the docs (I'm fine with it, sounds like this stuff no longer works), we should also mark the underlying APIs and features in InkAPI etc. as deprecated for 10.2 so we can delete those too from v11. |
|
I'm also fine with removing it. Nobody realized that it doesn't work as expected for a long time. The idea is nice if it works though. |
|
@moonchen will see if this feature can be fixed instead of just removing the documentation |
|
I'm +1 on a working feature. Guess my question is... is the right approach to bring back the documentation if/when it is working (eg, with the PRs that make it work)? |
The set-http-cntl TXN_DEBUG and (deprecated) set-debug need a non-overridable config (proxy.config.diags.debug.enabled) to be on. But, if its on, then you don't need header_rewrite to conditionally turn it on. (I suppose turning it off could be a use case, but, that would also require rewriting the docs).