Add TLS version mismatch tests to TestSSLHostConfigProtocol to verify…#973
Merged
dsoumis merged 1 commit intoapache:mainfrom Mar 31, 2026
Merged
Add TLS version mismatch tests to TestSSLHostConfigProtocol to verify…#973dsoumis merged 1 commit intoapache:mainfrom
dsoumis merged 1 commit intoapache:mainfrom
Conversation
… handshake failure when server and client support different protocol versions
| SSLContext sc = SSLContext.getInstance(Constants.SSL_PROTO_TLSv1_3); | ||
| sc.init(null, new TrustManager[] { new TesterSupport.TrustAllCerts() }, null); | ||
| TesterSupport.ClientSSLSocketFactory clientSSLSocketFactory = new TesterSupport.ClientSSLSocketFactory(sc.getSocketFactory()); | ||
| clientSSLSocketFactory.setProtocols(new String[] { Constants.SSL_PROTO_TLSv1_3 }); |
Contributor
There was a problem hiding this comment.
Client and server have different style interfaces (SSLHostConfig String vs TesterSupport String[]). Is this intentional? If it good/okay, or should we align them?
Member
Author
There was a problem hiding this comment.
It's intentional in the test scenario because String[] is expected in SSLSocket.setEnabledProtocols(String[] protocols). SSLHostConfig.setProtocols(String input) on the other hand, delimits values from a single string. I suppose we are good as it is.
Member
Author
There was a problem hiding this comment.
Using an array in xml would not be ideal.. :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… handshake failure when server and client support different protocol versions