Add test coverage for JsonErrorReportValve#965
Open
onkar717 wants to merge 2 commits intoapache:mainfrom
Open
Conversation
Member
|
You can utilize org.apache.tomcat.util.json.JSONParser to parse the response instead of using the body.contains() method. |
dsoumis
reviewed
Mar 23, 2026
| Assert.assertNotNull(body); | ||
| // Verify JSON structure | ||
| Assert.assertTrue("Response should contain type field", | ||
| body.contains("\"type\":")); |
dsoumis
reviewed
Mar 23, 2026
| Assert.assertNotNull(body); | ||
| // Verify JSON structure | ||
| Assert.assertTrue("Response should contain type field", | ||
| body.contains("\"type\":")); |
Member
There was a problem hiding this comment.
You can also verify that type contains a value of "errorReportValve.exceptionReport" or "errorReportValve.statusReport" equivalently for each test scenario
dsoumis
reviewed
Mar 23, 2026
|
|
||
| // Characters that require JSON escaping: quotes and backslashes | ||
| String specialMessage = | ||
| "Error with \"quotes\" and \\backslash\\ and <angle>"; |
Contributor
|
I have a similar JSON test here: https://github.com/apache/tomcat/blob/main/test/org/apache/catalina/manager/TestStatusTransformer.java#L115 |
onkar717
force-pushed
the
add-json-error-report-valve-tests
branch
from
5cb0b42 to
6f9926e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add dedicated test coverage for JsonErrorReportValve.
JsonErrorReportValve currently lacks specific tests compared to ErrorReportValve. This PR introduces TestJsonErrorReportValve to verify JSON error reporting behavior.
Motivation
JsonErrorReportValve does not currently have dedicated tests. Adding coverage helps ensure correctness and stability of JSON error reporting functionality.
Tests added
• JSON response for HTTP 500 errors
• JSON response for HTTP 404 errors
• Throwable information when exceptions occur
• JSON escaping of special characters
• Custom status code handling
• Chained exception handling
Implementation notes
Tests follow existing patterns from TestErrorReportValve and use TomcatBaseTest utilities. No new dependencies were introduced.
Impact
Improves test coverage and helps prevent regressions.
No production code changes were made.
This is a test-only change.