Fix doFinalReduction to remove keys when post-barrier steps produce nothing#3513
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.8-dev #3513 +/- ##
==========================================
Coverage ? 76.50%
Complexity ? 14916
==========================================
Files ? 1160
Lines ? 72219
Branches ? 8070
==========================================
Hits ? 55250
Misses ? 14032
Partials ? 2937 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Following my comment in the original PR, I think it's nonsensical that a non-productive by() would result in different behaviours (filter vs empty list) depending on if a barrier happens to be present. I agree this is a bug, as the semantics of group().by() should not have special cases for barriers, it would be inconsistent and unpredictable. For this reason, I think it's suitable for inclusion in 3.8-dev. VOTE +1 |
Contributor
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.