TIKA-4816 metadata key api - #3014
Merged
Merged
Conversation
…tion + typed minting factories
… (+strays), docs reconciliation
…tribution + key-shape renames
…ygiene Migrate every doc/tool-derived key-name call site onto KeyPrefix routes (mp4:, hdf:, isatab:, gdal:, dif:, network:, pages:, audio:), consolidate the duplicated DIFContentHandler, and promote remaining literal-key sites to curated Properties across the five migrated parser modules (scientific, audiovideo, apple, miscoffice, nlp), enforced by module-scoped forbiddenapis bans on Metadata's String-key and trusted write routes (main sources only). Registry scope expands to scientific/sqlite3/nlp/vlm with a module (artifactId) attribution field in both registries. Key hygiene: every Tika-coined key is now namespaced kebab-case (geotopic:*, grobid:tei:*, keynote:*, idml:/mif:, midi:/mp3:/ogg:/audio:*, iso19115:* -- retiring trailing-space/artifact spellings -- gdal:*, hdf:/netcdf:file-type- description, numbers:sheet-names), each bridged from its character-exact 3.x spelling via LegacyKeyMigrationFilter exact-rename overlay rows or prefix rules. Fixes surfaced en route: a systemic SIMPLE-vs-loop cardinality bug class (ISO19115, HDF, ISATab, XMPDM#LOG_COMMENT, vorbis catch-all -> BAG), a NetworkParser HTTP deadlock, GDAL regexes coupled to key text, MigrationTableGenerator's reflection-fragile validation and whitespace-stripping TSV parse, and an XML-invalid pom comment. Registries and migration table regenerated; all gates green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
blockReservedKeyWrite becomes checkNotReserved: Metadata#set/add(String, String) now throw IllegalArgumentException on reserved tk:/X-TIKA: names. With document-derived writers migrated off the String route (previous commit, including the ESReporterConfig load-time guard and test-route conversions that keep this flip's blast radius zero in-repo), the throw is unreachable from file input; it fires only on internal misuse (fail fast) or crafted files hitting unmigrated third-party parsers. Guard tests convert from drop- to throw-assertions; reconstruct/putAll/ trusted-route contracts unchanged. Full reactor green. Gated on the regression-corpus run before merge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tballison
marked this pull request as draft
August 12, 2026 20:04
…dimension review
…typed mint factories
tballison
marked this pull request as ready for review
August 13, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!