THRIFT-6109: Format Ruby HTTP transport endpoint labels

[kpumuk]

Replace the malformed diagnostic label returned by Thrift::HTTPClientTransport#to_s with an endpoint description that includes the scheme, host, port, and path.

The label distinguishes HTTP from HTTPS while leaving URL userinfo and query parameters out of logs and exception output.

• Did you create an Apache Jira ticket? THRIFT-6109
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

[Copilot]

Pull request overview

This PR updates the Ruby Thrift::HTTPClientTransport endpoint label (#to_s) to produce a structured, sanitized identifier based on scheme/host/port/path, and extends specs to ensure userinfo/query secrets don’t appear in the label.

Changes:

• Change Thrift::HTTPClientTransport#to_s to format as scheme(host:port/path) instead of returning the raw URL.
• Add spec coverage asserting #to_s omits URL userinfo and query parameters.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
lib/rb/spec/http_client_spec.rb	Updates/extends specs for HTTPClientTransport#to_s formatting and redaction.
lib/rb/lib/thrift/transport/http_client_transport.rb	Updates #to_s to emit a sanitized endpoint label (scheme/host/port/path).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

lib/rb/lib/thrift/transport/http_client_transport.rb:67

• to_s currently interpolates @url.host directly. For IPv6 literals, Ruby's URI typically returns the host without brackets (e.g. 2001:db8::1), which makes the host:port portion ambiguous and will not match the new spec expectation https([2001:db8::1]:8443/...). Wrap IPv6 hosts in [] when formatting the endpoint label.

      path = @url.path.to_s
      path = '/' if path.empty?
      "#{@url.scheme}(#{@url.host}:#{@url.port}#{path})"

[Jens-G]

Code review

No issues found. Checked for bugs, AGENTS.md compliance, and security implications.

🤖 Generated with Claude Code