Add input validation to Swift protocol layer#3392
Closed
Jens-G wants to merge 2 commits intoapache:masterfrom
Closed
Add input validation to Swift protocol layer#3392Jens-G wants to merge 2 commits intoapache:masterfrom
Jens-G wants to merge 2 commits intoapache:masterfrom
Conversation
Client: swift - Add recursion depth limit (64) and negative size checks to skip() in TProtocol for map, set, and list types - Add range validation for fieldId before UInt8 cast in TCompactProtocol.readFieldBegin() (07, 08) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jimexist
reviewed
Apr 11, 2026
| @@ -314,6 +314,10 @@ public class TCompactProtocol: TProtocol { | |||
| } | |||
|
|
|||
| // push the new field onto the field stack so we can keep the deltas going | |||
Member
There was a problem hiding this comment.
this comment belongs to the below line
jimexist
approved these changes
Apr 11, 2026
Client: swift Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: swift