Harden Node.js WebSocket server handling#3391
Open
Jens-G wants to merge 2 commits intoapache:masterfrom
Open
Conversation
Client: nodejs - Validate origin on WebSocket upgrade using the same CORS rules as HTTP requests - Fix path containment check to use trailing separator - Replace deprecated new Buffer() with Buffer.alloc() - Sanitize interpolated header values in upgrade response (04) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jimexist
reviewed
Apr 11, 2026
lib/nodejs/lib/thrift/web_server.js
Outdated
Comment on lines
+570
to
+572
| var origin = (request.headers.origin || "").replace(/[\r\n]/g, ""); | ||
| var host = (request.headers.host || "").replace(/[\r\n]/g, ""); | ||
| var reqUrl = (request.url || "").replace(/[\r\n]/g, ""); |
Member
There was a problem hiding this comment.
can have a dedicated function to do this
jimexist
approved these changes
Apr 11, 2026
Client: nodejs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: nodejs