Enable TLS hostname verification in TSSLTransportFactory#3390
Open
Jens-G wants to merge 1 commit intoapache:masterfrom
Open
Enable TLS hostname verification in TSSLTransportFactory#3390Jens-G wants to merge 1 commit intoapache:masterfrom
Jens-G wants to merge 1 commit intoapache:masterfrom
Conversation
Client: java Set EndpointIdentificationAlgorithm to HTTPS on SSLSocket parameters in createClient() so that the server certificate CN/SAN is validated against the target hostname during TLS handshake. (03) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jimexist
reviewed
Apr 11, 2026
Comment on lines
+347
to
+349
| SSLParameters sslParams = socket.getSSLParameters(); | ||
| sslParams.setEndpointIdentificationAlgorithm("HTTPS"); | ||
| socket.setSSLParameters(sslParams); |
jimexist
approved these changes
Apr 11, 2026
Member
Author
|
Yes — SSLParameters.setEndpointIdentificationAlgorithm("HTTPS") is available since Java 1.7. The only behavioral change is that connections where the server certificate doesn't match the target hostname will now be rejected. IOW, correct deployments are unaffected. |
Contributor
|
If enabled the TLS hostname verification in Java sync client, how about adding it in aync client as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: java
Set EndpointIdentificationAlgorithm to HTTPS on SSLSocket parameters in createClient() so that the server certificate CN/SAN is validated against the target hostname during TLS handshake.