Add recursion depth limit to Node.js protocol skip()#3389
Open
Jens-G wants to merge 1 commit intoapache:masterfrom
Open
Add recursion depth limit to Node.js protocol skip()#3389Jens-G wants to merge 1 commit intoapache:masterfrom
Jens-G wants to merge 1 commit intoapache:masterfrom
Conversation
Client: nodejs Add a depth parameter to skip() in TBinaryProtocol, TCompactProtocol, and TJSONProtocol to prevent stack exhaustion from deeply nested structures. Limit set to 64, matching the C++ and Java implementations. (01) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jimexist
approved these changes
Apr 11, 2026
Member
jimexist
left a comment
jimexist
left a comment
There was a problem hiding this comment.
not sure if 64 is meant to be made configurable?
Member
Author
|
The limit of 64 matches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: nodejs
Add a depth parameter to skip() in TBinaryProtocol, TCompactProtocol, and TJSONProtocol to prevent stack exhaustion from deeply nested structures. Limit set to 64, matching the C++ and Java implementations.