Skip to content

Replace addr with factory in TServerSocket#3379

Open
qr243vbi wants to merge 14 commits intoapache:masterfrom
qr243vbi:patch-1
Open

Replace addr with factory in TServerSocket#3379
qr243vbi wants to merge 14 commits intoapache:masterfrom
qr243vbi:patch-1

Conversation

@qr243vbi
Copy link
Copy Markdown

@qr243vbi qr243vbi commented Apr 7, 2026

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@qr243vbi
Copy link
Copy Markdown
Author

qr243vbi commented Apr 7, 2026

This allows to use named pipes from go-winio.

@mergeable mergeable bot added the golang patches related to go language label Apr 7, 2026
@Jens-G Jens-G requested a review from fishy April 8, 2026 23:13
@qr243vbi qr243vbi force-pushed the patch-1 branch 4 times, most recently from d57b3cc to 01ef926 Compare April 9, 2026 05:32
@qr243vbi qr243vbi requested a review from fishy April 9, 2026 05:34
@qr243vbi qr243vbi requested a review from fishy April 9, 2026 22:47
@qr243vbi qr243vbi requested a review from fishy April 10, 2026 02:27
Copy link
Copy Markdown
Member

@fishy fishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think "factory" is the best term here, maybe "listener" or something like that?

Also please squash your commits.

Comment on lines +64 to +65
// NewTServerSocketFromFactoryTimeout returns TServerSocket
// Allows full customization (TLS, mocks, unix sockets, windows named pipes, etc.)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like:

Suggested change
// NewTServerSocketFromFactoryTimeout returns TServerSocket
// Allows full customization (TLS, mocks, unix sockets, windows named pipes, etc.)
// NewTServerSocketFromFactoryTimeout creates TServerSocket via a listener factory.
//
// Allows full customization (TLS, mocks, unix sockets, windows named pipes, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

golang patches related to go language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants