TEZ-4715: Migrate Tez PB Protocols from ProtobufRPCEngine to ProtobufRPCEngine2#493
TEZ-4715: Migrate Tez PB Protocols from ProtobufRPCEngine to ProtobufRPCEngine2#493Aggarwal-Raghav wants to merge 1 commit intoapache:masterfrom
Conversation
|
(!) A patch to the testing environment has been detected. |
580e597 to
b459b5d
Compare
|
Jenkins is not updating the final status 😔 |
|
The UT failure debugging in #483 (comment) requires hadoop thirdparty making this PR dependent. TEZ-4715 + TEZ-4708 will completely migrate tez from |
|
@abstractdog From the code point of view, this seems right, We had to just use the RPCEngine2 & migrate to the Hadoop Thirdparty. That is rightly done here. But I think this would be an incompatible change, beyond this point I believe Hive master won't build nor work with Tez master. Hive has to do the same activity when moving to Tez-1.0.0 & that would be incompatible for Hive as well & believe the older Hadoop versions won't work post this activity in Hive or Tez, unless there was something done later to fix it, which I don't think... There were compat issues that is why I believe HADOOP-17046 was done later to make sure older client can work with them. Means protobuf is indeed a very known heavy Incompat change, a lot of discussion at HADOOP-13363, in case interested. These are the tradeoffs, I just wanted to highlight. Rest all cool |
com.google.protobufto shadedorg.apache.hadoop.thirdparty.protobuf