Skip to content

chore(build): remove the dead -Xelide-below scalac option #7709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aglinxinyuan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(build): remove the dead -Xelide-below scalac option #7709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea8e09f
chore(amber): remove the unused ElidableStatement
aglinxinyuan Aug 9, 2026
a3440a7
chore(build): remove the dead -Xelide-below scalac option
aglinxinyuan Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion access-control-service/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
4 changes: 0 additions & 4 deletions amber/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ Universal / mappings := AddMetaInfLicenseFiles.distMappings(
semanticdbEnabled := true
semanticdbVersion := scalafixSemanticdb.revision

// to turn on, use: INFO
// to turn off, use: WARNING
scalacOptions ++= Seq("-Xelide-below", "WARNING")

// to check feature warnings
scalacOptions += "-feature"
// to check deprecation warnings
Expand Down
34 changes: 0 additions & 34 deletions amber/src/main/scala/org/apache/texera/amber/engine/common/ElidableStatement.scala
View file
Open in desktop

This file was deleted.

141 changes: 0 additions & 141 deletions amber/src/test/scala/org/apache/texera/amber/engine/common/ElidableStatementSpec.scala
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion common/auth/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion common/config/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion common/dao/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ Compile / sourceGenerators += jooqGenerate

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion common/pybuilder/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion common/resource/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion common/util/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
2 changes: 0 additions & 2 deletions common/workflow-compiler/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ scalacOptions += "-Ymacro-annotations"
// Scala compiler options (mirrors the other common modules; `-Ywarn-unused:imports`
// is required by the scalafix RemoveUnused rule that CI runs via scalafixAll).
Compile / scalacOptions ++= Seq(
"-Xelide-below",
"WARNING",
"-feature",
"-deprecation",
"-Ywarn-unused:imports"
Expand Down
1 change: 0 additions & 1 deletion common/workflow-core/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ Test / testGrouping := {

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion common/workflow-operator/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ Test / testOptions ++= TestFilters.integrationSplit(

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion computing-unit-managing-service/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ libraryDependencies ++= Seq(

// Compiler Options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING",
"-feature",
"-deprecation",
"-Ywarn-unused:imports"
Expand Down
1 change: 0 additions & 1 deletion config-service/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion file-service/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion notebook-migration-service/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
1 change: 0 additions & 1 deletion workflow-compiling-service/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)

// Scala compiler options
Compile / scalacOptions ++= Seq(
"-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
Expand Down
Loading