refactor: untrack generated python proto, regenerate in build#5077
Open
Ma77Ball wants to merge 10 commits into
Open
refactor: untrack generated python proto, regenerate in build#5077Ma77Ball wants to merge 10 commits into
Ma77Ball wants to merge 10 commits into
Conversation
Contributor
Author
|
/request-review @Yicong-Huang |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5077 +/- ##
============================================
+ Coverage 43.35% 43.51% +0.16%
+ Complexity 2212 2210 -2
============================================
Files 1049 1051 +2
Lines 40560 40685 +125
Branches 4322 4322
============================================
+ Hits 17583 17703 +120
- Misses 21886 21887 +1
- Partials 1091 1095 +4
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks, that's a good direction for change! Let inline comments. Please make pr description concise. The "how you test" section is basically saying "ci" can verify. I don't get too much new info reading it. |
…o feat/changeProtobufGenerate
Contributor
Author
|
@Yicong-Huang, I addressed the comments. Please review when available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Stop version-tracking the betterproto-generated Python files under
amber/src/main/python/proto/. Add agenPythonProtosbt task that runsbin/python-proto-gen.shas a dependency ofWorkflowExecutionService/Compile/compile, with a graceful skip whenprotocis missing. Wireprotoc3.19.4 (matchingPB.protocVersion) andbetterproto[compiler]==2.0.0b7into the three image build stages (worker,master, web-app) and the three CI jobs that touch Python proto (python,python-state-materialization-mac,amber-integration). The 14th tracked file (proto/org/apache/texera/web/__init__.py) had no corresponding.protosource and is gone after regen; grep confirms no callers.Any related issues, documentation, or discussions?
Closes: #4102
How was this PR tested?
locally: sbt clean WorkflowExecutionService/compile regenerates the tree and pytest -m "not integration" passes; skip path verified with protoc absent. All three Docker images build end-to-end. CI covers the workflow YAML on
push.
Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF