Skip to content

fix: add quotes around enum string values in visualization operators #4351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuang7 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add quotes around enum string values in visualization operators #4351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e46f013
update.
xuang7 Apr 6, 2026
7b7180f
fix.
xuang7 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../scala/org/apache/texera/amber/operator/source/apis/reddit/RedditSearchSourceOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class RedditSearchSourceOpDesc extends PythonSourceOperatorDescriptor {
| client_secret = $clientSecretReal
| limit = $limit
| query = $queryReal
| sorting = ${sorting.getName}
| sorting = '${sorting.getName}'
|
| @overrides
| def produce(self) -> Iterator[Union[TupleLike, TableLike, None]]:
Expand Down
2 changes: 1 addition & 1 deletion ...texera/amber/operator/visualization/continuousErrorBands/ContinuousErrorBandsOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class ContinuousErrorBandsOpDesc extends PythonOperatorDescriptor {
fig.add_trace(go.Scatter(
x=table[${bandConf.xValue}],
y=table[${bandConf.yValue}],
mode=${bandConf.mode.getModeInPlotly},
mode='${bandConf.mode.getModeInPlotly}',
$colorPart
$namePart
))"""
Expand Down
2 changes: 1 addition & 1 deletion .../scala/org/apache/texera/amber/operator/visualization/contourPlot/ContourPlotOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class ContourPlotOpDesc extends PythonOperatorDescriptor {
| y=np.linspace(min(y), max(y), grid_size),
| z=grid_z,
| connectgaps=connGaps,
| contours_coloring =${coloringMethod.getColoringMethod},
| contours_coloring ='${coloringMethod.getColoringMethod}',
| colorbar_title=$z
| ))
| fig.update_layout(title='Contour Plot')
Expand Down
2 changes: 1 addition & 1 deletion .../scala/org/apache/texera/amber/operator/visualization/histogram2d/Histogram2DOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class Histogram2DOpDesc extends PythonOperatorDescriptor {
assert(yBins > 0, s"Y Bins must be > 0, but got $yBins")

val normArg =
pyb"histnorm=${normalize.getValue},"
pyb"histnorm='${normalize.getValue}',"

pyb"""
|from pytexera import *
Expand Down
Loading