fix: handle LakeFS pagination to return all results beyond default 100-item limit#4349
Open
xuang7 wants to merge 1 commit intoapache:mainfrom
Open
fix: handle LakeFS pagination to return all results beyond default 100-item limit#4349xuang7 wants to merge 1 commit intoapache:mainfrom
xuang7 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes the issue where retrieveUncommittedObjects and retrieveObjectsOfVersion only returned the first page of results (default 100 items). It adds a
fetchAllPagesmethod to retrieve the full result set across all pages. Each request sets.amount(1000)to reduce the number of round trips when fetching paginated results.When uploading 141 files:
Any related issues, documentation, discussions?
Resolves #4343
How was this PR tested?
Added a test that uploads 110 files to a temporary repo and verifies that both retrieveUncommittedObjects (before commit) and retrieveObjectsOfVersion (after commit) return all 110 items.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.6