fix(backend): auto-submit dataset version after exporting workflow results#4347
Open
seongjinyoon wants to merge 2 commits intoapache:mainfrom
Open
fix(backend): auto-submit dataset version after exporting workflow results#4347seongjinyoon wants to merge 2 commits intoapache:mainfrom
seongjinyoon wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
@seongjinyoon Per our recent discussion, please create an issue and describe the problem there. Then cite the issue in this PR. After that, I will assign people to review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Problem:
When exporting workflow execution results to a dataset, the exported files were only uploaded to the LakeFS staging area (uncommitted workspace). Users had to manually navigate to the Datasets tab, select the dataset, and click "Submit" to commit the staged files as a new dataset version.
This PR removes that manual step by automatically creating a dataset version after the file upload completes.
Changes:
commitDatasetVersion()method in ResultExportService that calls the file service's /{did}/version/create endpoint to commit staged files as a new dataset version.exportToDataset(), after all operator results are uploaded successfully, the method now callscommitDatasetVersion()for each target dataset.ENV_FILE_SERVICE_CREATE_DATASET_VERSION_ENDPOINTenvironment variable in EnvironmentalVariable for configuring the version creation endpoint URL.Any related issues, documentation, discussions?
#4348
How was this PR tested?
Manually tested.
Screen.Recording.2026-04-05.at.11.04.42.AM.mov
Was this PR authored or co-authored using generative AI tooling?
Revised with Claude Code.