Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables multi-link support on input ports in the workflow editor, aligning input-port connection behavior with existing output-port multi-link behavior (closes #4329).
Changes:
- Allows multiple links to connect to the same input port in the workflow editor connection validator.
- Updates workflow validation so input ports no longer require exactly one incoming link.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| frontend/src/app/workspace/service/validation/validation-workflow.service.ts | Adjusts operator connection validation logic for input ports to permit multi-link. |
| frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.ts | Relaxes UI connection validation to allow additional links into already-connected input ports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/app/workspace/service/validation/validation-workflow.service.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/workspace/service/validation/validation-workflow.service.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/workspace/service/validation/validation-workflow.service.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Outdated
Show resolved
Hide resolved
…low.service.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
Contributor
|
@Xiao-zhen-Liu Please review it. |
frontend/src/app/workspace/service/validation/validation-workflow.service.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Per offline discussion, we will change the flag from "allowMultiInputs" to "disallowMultiInputs", and disallow multi-inputs on visualization operators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Enabling multi-link support for input ports.
Any related issues, documentation, discussions?
Closes #4329
How was this PR tested?
Tested manually.
Was this PR authored or co-authored using generative AI tooling?
No.