Project: S3779 LZW ColGroup | ASML

[MasterBrain2000]

Group Project for the AMLS Module

[janniklinde]

Your code does not build (see error logs). Could you please fix those issues to have a prototype that compiles?

[janniklinde]

@MasterBrain2000 @m-ollka @Mancer1 could you please address the issues causing the tests to fail? Thanks

[Mancer1]

@janniklinde, all the build problems have been addressed.

[codecov]

Codecov Report

❌ Patch coverage is 90.77118% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.52%. Comparing base (d5f6950) to head (ccdbd3b).
⚠️ Report is 29 commits behind head on main.

Files with missing lines	Patch %	Lines
...ss/colgroup/ColGroupPiecewiseLinearCompressed.java	90.17%	31 Missing and 35 partials ⚠️
...ress/colgroup/functional/PiecewiseLinearUtils.java	92.85%	3 Missing and 3 partials ⚠️
...he/sysds/runtime/compress/colgroup/ColGroupIO.java	88.88%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2560      +/-   ##
============================================
- Coverage     71.61%   71.52%   -0.09%     
- Complexity    50132    50659     +527     
============================================
  Files          1614     1631      +17     
  Lines        193986   196297    +2311     
  Branches      37935    38267     +332     
============================================
+ Hits         138925   140405    +1480     
- Misses        44155    44897     +742     
- Partials      10906    10995      +89     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Mancer1]

@janniklinde, we have improved the coverage to 95%. I hope that suffices

[Mancer1]

@janniklinde, we have already reformatted our files that we edited. The files that java Codestyle check is showing to reformat are those not part of our PR.

rice@Arnor:~/MasterBrain2000-Project-S3779-LZW-ColGroup$  dev/format-changed.sh
All PR-edited Java lines are correctly formatted.
rice@Arnor:~/MasterBrain2000-Project-S3779-LZW-ColGroup$ git status
On branch main
Your branch is up to date with 'origin/main'.

So, should we leave it be, since we were working on a stale version of main?

[janniklinde]

You can simply run the following @Mancer1:

git fetch upstream
dev/format-changed.sh upstream/main

[Mancer1]

You can simply run the following @Mancer1:

git fetch upstream
dev/format-changed.sh upstream/main

@janniklinde, I believe I tried it before. It didn't affect anything.

rice@Arnor:~/MasterBrain2000-Project-S3779-LZW-ColGroup$ git fetch upstream
dev/format-changed.sh upstream/main
remote: Enumerating objects: 299, done.
remote: Counting objects: 100% (172/172), done.
remote: Compressing objects: 100% (90/90), done.
remote: Total 299 (delta 105), reused 82 (delta 82), pack-reused 127 (from 2)
Receiving objects: 100% (299/299), 262.07 KiB | 507.00 KiB/s, done.
Resolving deltas: 100% (122/122), completed with 16 local objects.
From https://github.com/apache/systemds
 * [new branch]            dependabot/github_actions/docker/login-action-4.6.0 -> upstream/dependabot/github_actions/docker/login-action-4.6.0
   7a0e5ca0ac..9dccbc3e60  main       -> upstream/main
All PR-edited Java lines are correctly formatted.
rice@Arnor:~/MasterBrain2000-Project-S3779-LZW-ColGroup$ git status
On branch main
Your branch is up to date with 'origin/main'.
```

[janniklinde]

Thanks for the updates. I left comments in the code which should still be fixed. Most of them are minor and easy to patch.

Please address those remaining issues to pass the project.

[janniklinde]

Let me know once all issues have been addressed for me to make a final pass over the code @Mancer1.

[Mancer1]

@janniklinde, I'll tell you when we're fully done with the changes. I'm just replying "Done" to your comments for better team coordination and to know which changes have been made.

[Mancer1]

@janniklinde, we have made the changes you have requested. You may rerun the workflows.

[Mancer1]

@janniklinde, as mentioned before, the Java Code Style failure happens on files that are not part of our PR. We have done both dev/format-changed.sh and dev/format-changed.sh upstream/main before we pushed our code.

[janniklinde]

I did another review pass and looks much better now. Most of the comments have been resolved. Have a look at the comments that are still open and the ones that I added now.

[Mancer1]

@janniklinde, could you perhaps rerun just the functions.mlcontext check? In our main branch, this check came out as successful.

[janniklinde]

I think this is wrong, sameIndexStructure, simply return false