Skip to content

[SYSTEMDS-3842] Improve test coverage of API components#2241

Closed
e-strauss wants to merge 1 commit intoapache:mainfrom
e-strauss:api_code_coverage
Closed

[SYSTEMDS-3842] Improve test coverage of API components#2241
e-strauss wants to merge 1 commit intoapache:mainfrom
e-strauss:api_code_coverage

Conversation

@e-strauss
Copy link
Copy Markdown
Contributor

@e-strauss e-strauss commented Mar 5, 2025

This PR extends the test coverage of the API components: DMLScript (96%) and CLIOptions (99.7%).

Additionally, I identified an unreachable code fragment in the codegen SpoofCompiler and added a TODO for further investigation.

Other API components will be addressed in separate PRs.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (e97f410) to head (2db8573).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2241      +/-   ##
============================================
+ Coverage     72.56%   72.64%   +0.08%     
- Complexity    45609    45656      +47     
============================================
  Files          1470     1470              
  Lines        171210   171213       +3     
  Branches      33452    33452              
============================================
+ Hits         124233   124384     +151     
+ Misses        37542    37409     -133     
+ Partials       9435     9420      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@e-strauss e-strauss force-pushed the api_code_coverage branch 2 times, most recently from 9453a3d to f9b29d6 Compare March 7, 2025 16:47
@e-strauss e-strauss changed the title [WIP] Improved test coverage of API: DMLOptions [SYSTEMDS-3842] Improve test coverage of API components Mar 7, 2025
@e-strauss e-strauss force-pushed the api_code_coverage branch from 0e290cc to 74ac36f Compare March 8, 2025 09:25
@e-strauss e-strauss requested a review from mboehm7 March 9, 2025 12:41
Copy link
Copy Markdown
Contributor

@Baunsgaard Baunsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once formatted.

@e-strauss e-strauss force-pushed the api_code_coverage branch from 74ac36f to 2db8573 Compare April 9, 2025 09:37
@e-strauss e-strauss removed the request for review from mboehm7 April 9, 2025 09:37
@e-strauss
Copy link
Copy Markdown
Contributor Author

@Baunsgaard thanks for the review, I fixed the formatting and rebased on the latest commit on main

@e-strauss e-strauss closed this in c4e7e46 Apr 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Apr 16, 2025
@e-strauss e-strauss deleted the api_code_coverage branch May 14, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants