#1951 refactor: replace linear proxy scan with lookup map in MultiProxyManager#1953
Closed
leedongkyu0407 wants to merge 1 commit into
Closed
#1951 refactor: replace linear proxy scan with lookup map in MultiProxyManager#1953leedongkyu0407 wants to merge 1 commit into
leedongkyu0407 wants to merge 1 commit into
Conversation
…ltiProxyManager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1951
Summary
Replace the O(n) linear scan in
getConfiguredProxy()with an O(1) map lookup.Changes
proxyLookupMapfield (HashMap keyed on normalized proxy identity)configure()overloads after proxies are loadedproxyKey()helper that normalizesprotocolandaddressto lowercase, consistent withProxyUtils.isSameProxy()getConfiguredProxy()with a map lookupNotes
ProxyUtils.isSameProxy()semanticsMultiProxyManagerTest: 13/13 passedProtocolTest.testBlockingfailure is pre-existing and unrelated to this change