#466 - Handle text/plain content in JSoupParserBolt#1943
Open
rzo1 wants to merge 1 commit into
Open
Conversation
dpol1
approved these changes
Jun 15, 2026
dpol1
left a comment
dpol1
left a comment
Member
There was a problem hiding this comment.
looks good. the shell-doc trick keeps redirects and filters working and leaves the html path untouched, nice.
text/plain content requires no markup parsing, so instead of raising an error (the default with jsoup.treat.non.html.as.error) the bolt now uses the decoded content directly as the extracted text and emits no outlinks. The plain-text path does not run the TextExtractor (there is no markup to extract from), so the two size-related knobs are read in prepare() and applied directly: empty text when textextractor.no.text is set, truncated to textextractor.skip.after otherwise. substring keeps the original layout, which is the point of a .txt; http.content.limit remains the bound for the raw fetched bytes. The include/exclude knobs require markup and have no effect. Adds unit tests for the verbatim, skip.after-truncation and no.text cases and documents the behaviour and bounds in configuration.adoc and internals.adoc. Closes #466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text/plain content requires no markup parsing, so instead of raising an error (the default with jsoup.treat.non.html.as.error) the bolt now uses the decoded content directly as the extracted text and emits no outlinks.
Adds a unit test and documentation updates.
Closes #466
For all changes
Is there a issue associated with this PR? Is it referenced in the commit message?
Does your PR title start with
#XXXXwhereXXXXis the issue number you are trying to resolve?Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
Is the code properly formatted with
mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?For code changes
mvn clean verify?Note
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.