Reject image tags that are neither mapped nor valid image hashes before building the manifest path - #8983
Open
rzo1 wants to merge 1 commit into
Open
Reject image tags that are neither mapped nor valid image hashes before building the manifest path#8983rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
…re building the manifest path
reiabreu
reviewed
Aug 19, 2026
| return hash; | ||
| } else { | ||
| if (!isValidHash(imageTag)) { | ||
| throw new IllegalArgumentException("Image tag " + imageTag |
Contributor
There was a problem hiding this comment.
minor: should we throw an IOException here to be coherent with the validation in getManifestFromImageTag?
reiabreu
approved these changes
Aug 19, 2026
Contributor
|
great job! |
reiabreu
reviewed
Aug 19, 2026
| @Override | ||
| public synchronized ImageManifest getManifestFromImageTag(String imageTag) throws IOException { | ||
| String hash = getHashFromImageTag(imageTag); | ||
| if (!isValidHash(hash)) { |
Contributor
There was a problem hiding this comment.
another minor one caught by LLM: hdfsImageToHash and localImageToHashCache are built from readImageToHashFile, which already does this validation. It's not necessarily wrong to have this here, since it's defensive in case readImageToHashFile changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHashFromImageTagreturned the raw image tag when it was absent from both the local and HDFS tag-to-hash caches, and that value was concatenated into the manifest path without being held to the 64-character alphanumeric rule that mapped entries must satisfy.Adds an
isValidHashcheck on the fallback and before the manifest path is built, and reuses it for the existing parse-time check. Adds the first test class for this module, along with its test dependencies.