[MINOR][BUILD] Drop retired oro dependency#57492
Open
ybapat wants to merge 3 commits into
Open
Conversation
oro (Jakarta ORO) was retired 16 years ago. It was pulled in as an optional runtime dependency of Apache Ivy, but modern Ivy versions work correctly without it. Remove the dependency declaration, the version property, and the entry from the tracked deps manifest. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
oro was listed as a bundled binary dependency. Companion to the removal of the oro dependency declaration from pom.xml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
uros-b
requested changes
Jul 24, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
The removal's stated rationale is empirically false for the pinned Ivy 2.5.3, whose GlobPatternMatcher hard-requires org.apache.oro, and Spark's --packages path always builds glob exclude rules; so this turns every Maven-coordinate resolution into a NoClassDefFoundError. To drop oro, Spark must first migrate MavenUtils off GlobPatternMatcher (e.g. RegexpPatternMatcher / ExactPatternMatcher) and prove resolution plus the existing MavenUtilsSuite pass without oro on the classpath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the
oro(Jakarta ORO) dependency from Apache Spark.<oro.version>2.0.8</oro.version>property from the rootpom.xmlorodependency block fromcommon/utils/pom.xmloro/2.0.8//oro-2.0.8.jarentry fromdev/deps/spark-deps-hadoop-3-hive-2.3oro:oroentry fromLICENSE-binaryWhy are the changes needed?
The
oro(Jakarta ORO) project was officially retired approximately 16 years ago. It was added to Spark 12 years ago as an optional runtime dependency of Apache Ivy (see the inline comment: "oro is needed by ivy, but only listed as an optional dependency"). Modern Ivy (2.5.x, which Spark currently uses) falls back tojava.util.regexwhenorois absent, so the jar is no longer needed.No Spark source code directly imports
org.apache.oro.*; the jar served only as an optional Ivy runtime detail.Relates to GitHub issue #57209.
Does this PR introduce any user-facing change?
No. This is a build-level dependency removal with no runtime impact on Spark users.
How was this patch tested?
The dependency manifest (
dev/deps/spark-deps-hadoop-3-hive-2.3) andLICENSE-binarywere updated to remove all traces of theoroartifact. No Spark source files importorg.apache.oro, so no code changes or tests are required.