[SPARK-56182][SQL] Allow SPJ reducing identity to other transforms#54980
Open
peter-toth wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56182][SQL] Allow SPJ reducing identity to other transforms#54980peter-toth wants to merge 1 commit intoapache:masterfrom
peter-toth wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I will rebease this PR once the bug fix #54961 landed. |
peter-toth
force-pushed
the
SPARK-56182-reduce-identity-to-other-transforms
branch
from
17a1d3b to
b5fc337
Compare
peter-toth
changed the title
Contributor
Author
|
cc @dongjoon-hyun , @szehon-ho |
peter-toth
force-pushed
the
SPARK-56182-reduce-identity-to-other-transforms
branch
from
b5fc337 to
c13f167
Compare
dongjoon-hyun
approved these changes
Mar 24, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for rebasing, @peter-toth !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extended
KeyedShuffleSpecto support storage-partitioned joins (SPJ) where one side uses an identity transform (represented asAttributeReference) and the other side uses an arbitraryTransformExpression.Why are the changes needed?
Previously, SPJ with compatible transform reduction only worked for
(TransformExpression, TransformExpression)pairs. If one data source partitions by identity and the other by an arbitrary transform (e.g. bucket), SPJ was not triggered even though the identity side's raw values can be reduced by simply applying the transform.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new test case.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 4.6