[SPARK-56180][INFRA] build/mvn prefer to download tgz from maven central#54979
Open
pan3793 wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56180][INFRA] build/mvn prefer to download tgz from maven central#54979pan3793 wants to merge 1 commit intoapache:masterfrom
build/mvn prefer to download tgz from maven central#54979pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Is the PR title correct?
[SPARK-56180][INFRA] build/mvn prefer to download tgz from maven central
According to the PR description and code, this PR wants to prefer Google Mirror, doesn't it, @pan3793 ?
Change dev/check-license to use Google mirror instead of https://repo1.maven.org/maven2 when DEFAULT_ARTIFACT_REPOSITORY is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate
build/mvndefault tgz downloading from ASFcloser.luato Maven Central (DEFAULT_ARTIFACT_REPOSITORY, default points to Google mirror).Also, improve other scripts that use
DEFAULT_ARTIFACT_REPOSITORY, now it works well with and without a trailing slash.Change
dev/check-licenseto use Google mirror instead of https://repo1.maven.org/maven2 whenDEFAULT_ARTIFACT_REPOSITORYis absent.Why are the changes needed?
ASF services have not been very stable recently, this change reduces load on the ASF download site.
closer.luaroutes the downloading to either the ASF dlcdn site (powered by CDN) or archive site (slow and unstable), while Maven Central preserves all historical versions, so this also benefits older branches that use old Maven versions (if we backport it to older branches).Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested - fresh clone spark repo, and run
build/mvn,build/sbt,dev/check-license.Was this patch authored or co-authored using generative AI tooling?
No.