[WIP][SPARK-XXXXX][SQL] Replace legacy error codes with named errors in DSv2 connector API#54971
Open
dbtsai wants to merge 1 commit intoapache:masterfrom
Open
[WIP][SPARK-XXXXX][SQL] Replace legacy error codes with named errors in DSv2 connector API#54971dbtsai wants to merge 1 commit intoapache:masterfrom
dbtsai wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaced 18 LEGACY_ERROR_TEMP* error codes in the Data Source V2 (DSv2) connector API with properly named, descriptive error conditions. The affected interfaces are all in
sql/catalyst/src/main/java/org/apache/spark/sql/connector/:
New error names follow established Spark conventions (DATASOURCE_, PARTITION_, V2_EXPRESSION_SQL_BUILDER_, UNEXPECTED_) and are inserted alphabetically into error-conditions.json. All new entries
include a sqlState (0A000 for unsupported operations, 42000 for illegal arguments) and messages ending with a period.
Why are the changes needed?
Legacy error codes (LEGACY_ERROR_TEMP*) are opaque and hard to search, cross-reference, or document. Named error codes make it easier for users and downstream connectors to identify and handle specific
error conditions.
Does this PR introduce any user-facing change?
Yes — error messages now include a sqlState and names are surfaced in error output, but the message text is preserved (with minor normalization: trailing periods added for consistency).
How was this patch tested?
Existing unit and integration tests cover these code paths. No behavioral changes were made.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code