[SPARK-56168][PS][TESTS] Relax groupby diff-length assertions for pandas 3#54969
Closed
ueshin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56168][PS][TESTS] Relax groupby diff-length assertions for pandas 3#54969ueshin wants to merge 1 commit intoapache:masterfrom
ueshin wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
zhengruifeng
approved these changes
Mar 24, 2026
HyukjinKwon
approved these changes
Mar 24, 2026
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the pandas-on-Spark diff-frame groupby length test in
test_groupby_diff_len.py.The changes are test-only:
subTestto make the failing case easier to identifyalmost=Truefor pandas 3.xas_index=Falseand can widen their dtype after aligning mismatched lengthsWhy are the changes needed?
The test behavior differs across pandas versions for mismatched-length external group keys.
With pandas 3.x,
groupby(..., as_index=False)can include the external group key in the result and widen its dtype after alignment. That makes the strict equality used by this test fail due to dtype differences even though the grouped values still match.This patch keeps the existing pandas 2 behavior untouched and relaxes the assertions only for pandas 3.x in this localized test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Updated the related tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)