[SPARK-56155][SQL] Collect_list/collect_set sql() function includes "RESPECT NULLS"#54957
Open
helioshe4 wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56155][SQL] Collect_list/collect_set sql() function includes "RESPECT NULLS"#54957helioshe4 wants to merge 1 commit intoapache:masterfrom
helioshe4 wants to merge 1 commit intoapache:masterfrom
Conversation
helioshe4
commented
Mar 23, 2026
| } | ||
|
|
||
| override def sql(isDistinct: Boolean): String = { | ||
| val distinct = if (isDistinct) "DISTINCT " else "" |
Contributor
Author
There was a problem hiding this comment.
isDistinct should always be false for CollectSet because it gets removed in EliminateDistinct from Optimizer.scala
but i will keep it here for now to be consistent with the other aggregate functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the pretty string for collect_list/set column alias. When collect_list/collect_set appear in the column header, the string includes "RESPECT NULLS".
Why are the changes needed?
For clarity. Output may be misleading if we don't show 'RESPECT NULLS' in the column header even when user has included it.
Does this PR introduce any user-facing change?
Yes. Column headers now include 'RESPECT NULLS' when the keyword has been included.
How was this patch tested?
UT in
DataFrameAggregateSuiteWas this patch authored or co-authored using generative AI tooling?
No