Skip to content

[HISTORY] History server disk store lease should remove temp path delete hook after commit and rollback to avoid memory leak #54947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LennonChin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[HISTORY] History server disk store lease should remove temp path delete hook after commit and rollback to avoid memory leak #54947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/scala/org/apache/spark/deploy/history/HistoryServerDiskManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import org.apache.spark.internal.config.History.HybridStoreDiskBackend.ROCKSDB
import org.apache.spark.status.KVUtils
import org.apache.spark.status.KVUtils._
import org.apache.spark.util.{Clock, Utils}
import org.apache.spark.util.ShutdownHookManager
import org.apache.spark.util.kvstore.KVStore

/**
Expand Down Expand Up @@ -321,6 +322,7 @@ private class HistoryServerDiskManager(
val newSize = sizeOf(tmpPath)
makeRoom(newSize)
tmpPath.renameTo(dst)
ShutdownHookManager.removeShutdownDeleteDir(tmpPath)

updateUsage(newSize, committed = true)
if (committedUsage.get() > maxUsage) {
Expand All @@ -343,6 +345,7 @@ private class HistoryServerDiskManager(
def rollback(): Unit = {
updateUsage(-leased)
Utils.deleteRecursively(tmpPath)
ShutdownHookManager.removeShutdownDeleteDir(tmpPath)
}

}
Expand Down