[SPARK-55132][INFRA] Upgrade numpy version on lint image#53913
[SPARK-55132][INFRA] Upgrade numpy version on lint image#53913gaogaotiantian wants to merge 2 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Improvement SPARK-55132 === This comment was automatically generated by GitHub Actions |
|
In this case, would it be better to unpin the version so docker file picks up the latest version by default? |
|
I think that's the same dilemma for pinning |
zhengruifeng
left a comment
There was a problem hiding this comment.
LGTM pending CI
BTW, we may also want to upgrade the python version here, have a try if you are interested
|
Sure we can upgrade to 3.12. I think ideally we should do python lint check on all supported versions - but that's low priority. We don't have to do it on different workflows. We should be able to quickly switch between versions and do checks. |
|
thanks, merged to master |
What changes were proposed in this pull request?
Upgrade numpy version on lint image and fixed some minor lint failures.
Why are the changes needed?
When we do
pip install ./dev/requirements.txtlocally, we normally have the latest version ofnumpy. This creates a diff between our local dev environment and CI. We should keep this as close as possible so we can rely on local mypy results.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally mypy test passed.
Was this patch authored or co-authored using generative AI tooling?
No